fix preview in notebooks#1007
Open
seeM wants to merge 2 commits into
Open
Conversation
This fixes a bug where notebooks were failing to preview with error 'No Quarto document available to render'. The problem is that notebook cell text editors disappear from `vscode.window.visibleTextEditors` when either the bottom Panel or the Secondary Sidebar are visible. I'm unsure what the cause is, but it seems like a Code OSS bug or perhaps intentional change in behavior. The fix is to stop requiring a text editor in the notebook case. `QuartoEditor.textEditor` is only used in one place today: `PreviewManager.detectErrorNavigation` which is already skipped for notebooks, so it's safe to remove for notebooks. This allows us to remove the `visibleTextEditors` check. Since `QuartoEditor` still requires a `TextDocument` reference, we now use the first notebook cell, if one exists. Fixes #1006.
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where notebooks were failing to preview with error 'No Quarto document available to render'.
The problem is that notebook cell text editors disappear from
vscode.window.visibleTextEditorswhen either the bottom Panel or the Secondary Sidebar are visible. I'm unsure what the cause is, but it seems like a Code OSS bug or perhaps intentional change in behavior.The fix is to stop requiring a text editor in the notebook case.
QuartoEditor.textEditoris only used in one place today:PreviewManager.detectErrorNavigationwhich is already skipped for notebooks, so it's safe to remove for notebooks. This allows us to remove thevisibleTextEditorscheck.Since
QuartoEditorstill requires aTextDocumentreference, we now use the first notebook cell, if one exists.Fixes #1006.