Fix notebook preview#1003
Draft
seeM wants to merge 20 commits into
Draft
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
seeM
force-pushed
the
fix/notebook-preview
branch
from
af78296 to
d8d1730
Compare
vezwork
reviewed
Jun 12, 2026
Comment on lines
+56
to
62
| function isNotebook(doc?: vscode.TextDocument | vscode.NotebookDocument): doc is vscode.NotebookDocument { | ||
| return !!doc && 'notebookType' in doc; | ||
| } | ||
|
|
||
| export function isNotebookUri(uri: Uri) { | ||
| function isIpynbUri(uri: Uri) { | ||
| return extname(uri.fsPath).toLowerCase() === ".ipynb"; | ||
| } |
Member
There was a problem hiding this comment.
-
Nit: prefer
dog !== undefinedover!!docfor messiness of truthiness reasons -
Could you add a comment explaining why
'notebookType' in docis the thing to check forisNotebook? Is notebook that same as ipynb? If we're changingisNotebookUritoisIpynbUri, should we also changeisNotebooktoisIpynb?
vezwork
reviewed
Jun 12, 2026
| const frontMatter = targetEditor.notebook | ||
| ? targetEditor.notebook.cellAt(0)?.document.getText() || "" | ||
| : documentFrontMatterYaml(this.engine_, targetEditor.document); | ||
| const frontMatter = targetEditor.frontMatterYaml(this.engine_); |
Member
There was a problem hiding this comment.
why is there less cases than before? It doesn't look like targetEditor.frontMatterYaml in editor.ts captures all these cases?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.