Conversation
Light mode inherited cosmo's #2780e3, which puts white text at 3.97:1 (badges, .btn-primary, Quarto's notebook-preview header; axe color-contrast). Use #447099, the dark theme's $blue: white is 5.22:1 and the faded notebook h6 is 4.59:1.
Contributor
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-2241.quarto.org |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Light mode did not set
$primary, so it used the cosmo default,#2780e3. White text on this color is 3.97:1, and text needs 4.5:1 (WCAG 1.4.3). This affects the badges on the triaging page and the header of Quarto's notebook preview. Light mode now uses#447099, which is the dark theme's$blue.#447099is 5.22:1. The notebook-preview title, which Quarto shows atopacity: .9, is 4.59:1.$primaryalso sets the default Mermaid colors and the focus-ring color. The Mermaid labels change from bright blue to the brand blue. Links, callouts, and dark mode do not change.Checked with an axe scan of
docs/triaging/index.htmlanddocs/authoring/penguins-preview.htmlbefore and after:color-contrast(8 instances) is gone. Nothing is new or worse. Full-site scan (all 374 pages, light and dark, before and after all five batch fixes): this finding is gone, and nothing is new or worse.Check (light mode)