Conversation
…ttons The manuscripts .tool buttons hard-coded #373a3c text with no dark-mode rule (1.59:1 on #151515, axe color-contrast). Split the rule into light and dark variants as get-started does, and lighten the dark border on both pages to #6c757d (3.89:1) so the button outlines stay visible.
Contributor
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-2237.quarto.org |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In dark mode, the tool buttons on the manuscripts page have
#373a3clabels on#151515. This is 1.59:1, and text needs 4.5:1 (WCAG 1.4.3).docs/manuscripts/tutorial.csshad no dark-mode rule for the buttons.docs/get-started/tutorial.cssalready has one.#6c757d(3.89:1). The old dark border was 1.3:1, so the button outlines were almost invisible.Checked with an axe scan of
docs/manuscripts/index.htmlbefore and after:color-contrast(3 instances) is gone. A scan of all 22 get-started pages shows no change. Nothing is new or worse.Check (dark mode)