Conversation
Contributor
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-2233.quarto.org |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
tools-tabsetfilter puts a<h3>Choose your tool</h3>inside theul[role=tablist]. A tablist can contain only tabs, so axe reports a criticalaria-required-childrenerror on three pages (docs/books/,docs/websites/,docs/websites/website-blog.html). Theh3also adds an empty "Choose your tool" entry to the heading outline of each page.This PR:
aria-label="Choose your tool"to the tablist.<p aria-hidden="true">outside the list, in a flex row with the tabs.At desktop width, the tabs look the same as before. At 320px, the label is now on its own row, above a 2×2 grid of tabs.
An axe scan of the three pages, before and after the change, removes
aria-required-children :: .nav(3 instances) and shows no new findings.