[Sync to prerelease] Fix heading levels on the download pages - #2231
Merged
Merged
Conversation
Highlights and Release Notes become h2, the index tabsets split on h1, and populateNews() shifts changelog headings down one level instead of flattening them all to h6. (cherry picked from commit 474c282)
Member
|
/deploy-preview |
Contributor
Author
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-2231.quarto.org |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sync of #2228 to
prerelease.Original PR
Fix heading levels on the download pages
The download pages skip heading levels, and axe reports
heading-orderon each page. The outline goes from the h1 title to h3 "Highlights" and "Release Notes", then to h6 changelog headings.This PR:
docs/download/index.qmdfrom##to#. As a result, the h2 sections stay inside their tab.populateNews()in_download.html. It moved every changelog heading to h6. Now it moves each heading down one level (##to h3,###to h4), so the changelog keeps its structure.The headings are now larger than before.
Checked with an axe scan before and after on
docs/download/{index,release,prerelease}.html: the fourheading-orderfindings are gone, and nothing is new or worse. The tabs on the index page are unchanged.Check