Fix heading levels on the listing card pages - #2229
Merged
Merged
Conversation
Fixes axe heading-order on the Guide and Reference index pages. CSS keeps the previous h4/h6 appearance.
Contributor
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-2229.quarto.org |
Contributor
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The listing template
ejs/links.ejsmakes each card title an h4 and each subtitle an h6. The pages that use it go from the h1 title straight to h4, and axe reportsheading-orderon each card.This PR:
styles.cssso the cards look the same as before.Checked with an axe scan before and after on the six pages that use the template: all 19
heading-orderinstances are gone, and nothing is new or worse. The computed font size, weight, colour and spacing of the titles are the same in light and dark mode.Check