Repository navigation
fix(supervisor): require a health pass for the process that is up - #40
Merged
Merged
Conversation
wait --healthy and ensure treated a running phase as ready. That phase stays running through health checks that are still failing, and a pass recorded for the previous process was never cleared, so a restarted server could be reported ready while its port still refused connections. A healthy result now requires a passing check for the current process and a latest check that passed. The previous process's exit stays off the new run's status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
directa wait --healthycould return as soon as a server's phase wasrunning, including right after a restart, while that process was still refusing connections. The phase staysrunningthrough health checks that have started failing, and a passing check from the previous process was kept and treated as the new one's.wait --healthyandensurenow wait until a health check has passed for the process that is up, and they keep waiting while the latest check is failing. Status for that process no longer shows the previous process's exit.Verified with
make testandscripts/smoke.sh. The new health tests also passed underscripts/test-narrow-pool.shwith the pool narrowed and no blocked threads.