Land example-asset upload, CI matrix, and Ruff linting#58
Merged
Conversation
Pin Ruff's effective configuration so a future Ruff upgrade can't silently change what CI enforces: - line-length = 88 (current default) - target-version = py310 (matches requires-python) - lint.select = current default set (E4, E7, E9, F) No behaviour change: ruff check . still passes. Comment documents how to broaden (e.g. I for import sorting, UP for pyupgrade). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The Node 20 action runtime is deprecated: GitHub forces Node 24 from 2026-06-16 and removes Node 20 on 2026-09-16. Update to the latest majors, which run on Node 24: - actions/checkout v4 -> v6 - actions/setup-python v5 -> v6 - actions/upload-artifact v4 -> v7 (release.yml) - actions/download-artifact v4 -> v8 (release.yml) upload-artifact v7 and download-artifact v8 co-evolved and remain compatible; the default zip round-trip used here is unchanged. pypa/gh-action-pypi-publish is a container action and is unaffected. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
push.branches "**" matched every branch, so each commit on a PR branch triggered both a push run and a pull_request run for the same SHA. Scope push to master; pull_request already covers all PRs (including forks, built against the merge result). Branches without an open PR no longer build until a PR is opened. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the modernization stack pr2-release-example-assets + pr3-add-ci-and-ruff onto master. Both were merged into their stacked bases (#51, #52) but the final master-bound PR never opened, so this work has been sitting unmerged.
Cherry-picks instead of a stack merge — pr3's bottom commit duplicates #50's packaging work which is already on master, so a direct merge conflicts. The Node-24 actions bump (
9259493) overlaps with #55 and was reduced from 8/8 to 3/3 lines on the cherry-pick.Contents:
.github/workflows/ci.yml— Python 3.10–3.14 matrix on PRs and master pushes.github/workflows/release.yml— adds Ruff linting andqtm-rt-examples.ziprelease-asset upload (zipsexamples/+Demo.qtm)MANIFEST.in— controls sdist contentspyproject.toml— Ruff rulesetqtm_rt/__init__.py— drop the deadPYTHON3Python-2 import gateqtm_rt/*andtest/*asyncio_everything.py,stream_6dof_example.py) refactored for modern asyncio + the new asset pathTested: all 81 tests pass locally.