Skip to content

Added Semgrep_Rules/rules.yaml and update semgrep-cli-options - #46

Open
yeswantr wants to merge 2 commits into
qualcomm:mainfrom
yeswantr:add-semgrep-rules
Open

Added Semgrep_Rules/rules.yaml and update semgrep-cli-options#46
yeswantr wants to merge 2 commits into
qualcomm:mainfrom
yeswantr:add-semgrep-rules

Conversation

@yeswantr

Copy link
Copy Markdown

This PR adds a Semgrep_Rules directory at the root of the repository and updates the reusable Semgrep scan workflow to include custom Qualcomm security rules.

Changes Made:

  • Added Semgrep_Rules/rules.yaml sourced from the internal qpsi repository
  • Updated semgrep-cli-options in .github/workflows/reusable-semgrep-scan.yml to include: --config auto --config Semgrep_Rules/rules.yaml

References

@mynameistechno

Copy link
Copy Markdown
Collaborator

yeswantr can you join the qualcomm org please? see New Contributor Checklist at go/qcomgithub

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a repository-local Semgrep ruleset and updates the reusable Semgrep scan workflow default options so runs include Qualcomm’s custom security rules by default.

Changes:

  • Added Semgrep_Rules/rules.yaml containing a large set of custom Semgrep rules.
  • Updated .github/workflows/reusable-semgrep-scan.yml default semgrep-cli-options to load both --config auto and the new local rules file.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
Semgrep_Rules/rules.yaml Adds the custom Qualcomm Semgrep ruleset to be referenced by workflows.
.github/workflows/reusable-semgrep-scan.yml Updates the reusable workflow’s default Semgrep CLI options to include the new rules file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 5 to 9
semgrep-cli-options:
required: false
type: string
default: '--config auto'
default: '--config auto --config Semgrep_Rules/rules.yaml'
description: 'CLI options for semgrep scan (e.g., "--config p/security-audit --severity ERROR"). Must be valid CLI flags only.'
@mynameistechno

Copy link
Copy Markdown
Collaborator

yeswantr can you join the qualcomm org please? see New Contributor Checklist at go/qcomgithub

Please review our internal guidelines at go/qcomgithub and go/osdo. You're not using the correct open source identity in your commits and not signing off the commits either. Please correct the existing commits.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my existing comments to fix commit authorship.

@mynameistechno

Copy link
Copy Markdown
Collaborator

Also please see go/ossbestpracticesdoc for commit message best practices.

@mynameistechno

Copy link
Copy Markdown
Collaborator

Avoid posting internal-only full URLs externally on the public GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants