Added Semgrep_Rules/rules.yaml and update semgrep-cli-options - #46
Added Semgrep_Rules/rules.yaml and update semgrep-cli-options#46yeswantr wants to merge 2 commits into
Conversation
|
yeswantr can you join the qualcomm org please? see New Contributor Checklist at go/qcomgithub |
There was a problem hiding this comment.
Pull request overview
This PR introduces a repository-local Semgrep ruleset and updates the reusable Semgrep scan workflow default options so runs include Qualcomm’s custom security rules by default.
Changes:
- Added
Semgrep_Rules/rules.yamlcontaining a large set of custom Semgrep rules. - Updated
.github/workflows/reusable-semgrep-scan.ymldefaultsemgrep-cli-optionsto load both--config autoand the new local rules file.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Semgrep_Rules/rules.yaml |
Adds the custom Qualcomm Semgrep ruleset to be referenced by workflows. |
.github/workflows/reusable-semgrep-scan.yml |
Updates the reusable workflow’s default Semgrep CLI options to include the new rules file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| semgrep-cli-options: | ||
| required: false | ||
| type: string | ||
| default: '--config auto' | ||
| default: '--config auto --config Semgrep_Rules/rules.yaml' | ||
| description: 'CLI options for semgrep scan (e.g., "--config p/security-audit --severity ERROR"). Must be valid CLI flags only.' |
Please review our internal guidelines at go/qcomgithub and go/osdo. You're not using the correct open source identity in your commits and not signing off the commits either. Please correct the existing commits. |
Mark Matyas (mynameistechno)
left a comment
There was a problem hiding this comment.
See my existing comments to fix commit authorship.
|
Also please see go/ossbestpracticesdoc for commit message best practices. |
|
Avoid posting internal-only full URLs externally on the public GitHub. |
This PR adds a
Semgrep_Rulesdirectory at the root of the repository and updates the reusable Semgrep scan workflow to include custom Qualcomm security rules.Changes Made:
Semgrep_Rules/rules.yamlsourced from the internal qpsi repositorysemgrep-cli-optionsin.github/workflows/reusable-semgrep-scan.ymlto include:--config auto --config Semgrep_Rules/rules.yamlReferences