GStreamer imsdk camera test suite#405
Conversation
5638a88 to
54e7f3b
Compare
There was a problem hiding this comment.
This PR would be much easier to review and maintain if it is reduced to the minimum supported feature set.
Right now the suite is over-expanded for an initial submission: the runner is very large, the README is very long, and the shared library change includes helper additions that do not appear to be required by the suite’s current execution path.
Please tighten this PR. Suggested cleanup:
-
Remove interfaces that are not actually implemented end-to-end yet
- e.g.
--test-name/CAMERA_TEST_NAMEif single-test filtering is not wired up - remove snapshot-related helper additions if snapshot tests are not actually executed
- e.g.
-
Keep only shared
lib_gstreamer.shhelpers that are used by this suite today -
Reduce the README to the essentials
- overview
- prerequisites
- actual supported test matrix
- parameters
- basic troubleshooting
-
Split into 2 commits
- shared helper additions
- Camera_Tests suite files
-
Fix the YAML wrapper to the repo-standard form while respinning
If needed, it would also be reasonable to reduce this to a smaller MVP first (for example only the verified backend/test paths), and then add more coverage in follow-up PRs.
|
smuppand
left a comment
There was a problem hiding this comment.
Please squash the commits into
At most, 2 logical commits would make sense:
- shared
Runner/utils/[lib_gstreamer.sh](http://lib_gstreamer.sh/)helper additions Camera_Testssuite files
Signed-off-by: nitinn <nitinn@qti.qualcomm.com>
72274d8 to
e6e24b7
Compare
|
quashed commits as suggested.
Please review. Thanks! |
ff80587 to
35f4a80
Compare
smuppand
left a comment
There was a problem hiding this comment.
The PR is much closer now, and I no longer see the previous major structural blockers. Only minor comment fixes and the main shell lint issues remain.
adecc41 to
99ff31a
Compare
| - cd "$REPO_PATH/Runner/suites/Multimedia/GSTreamer/Camera/Camera_Tests" | ||
| - export CAMERA_ID CAMERA_PLUGIN CAMERA_TEST_MODES CAMERA_FORMATS CAMERA_RESOLUTIONS CAMERA_FRAMERATE CAMERA_DURATION CAMERA_GST_DEBUG | ||
| - ./run.sh --camera-id "${CAMERA_ID}" --plugin "${CAMERA_PLUGIN}" --test-modes "${CAMERA_TEST_MODES}" --formats "${CAMERA_FORMATS}" --resolutions "${CAMERA_RESOLUTIONS}" --framerate "${CAMERA_FRAMERATE}" --duration "${CAMERA_DURATION}" --gst-debug "${CAMERA_GST_DEBUG}" --lava-testcase-id "${LAVA_TESTCASE_ID}" || true | ||
| - "$REPO_PATH/Runner/utils/send-to-lava.sh" Camera_Tests.res |
There was a problem hiding this comment.
This line in the current YAML is invalid YAML. Because YAML reads the first quoted part as one complete string.
definition: lava
case: job
result: fail
error_msg: Unable to open test definition 'Runner/suites/Multimedia/GSTreamer/Camera/Camera_Tests/Camera_Tests.yaml': while parsing a block collection in "/var/lib/lava/dispatcher/tmp/182770/lava-overlay-en67i_an/home/lava-182770/0/tests/0_Weston_Runtime_Preflight/Runner/suites/Multimedia/GSTreamer/Camera/Camera_Tests/Camera_Tests.yaml", line 28, column 5 did not find expected '-' indicator in "/var/lib/lava/dispatcher/tmp/182770/lava-overlay-en67i_an/home/lava-182770/0/tests/0_Weston_Runtime_Preflight/Runner/suites/Multimedia/GSTreamer/Camera/Camera_Tests/Camera_Tests.yaml", line 32, column 49
error_type: Job
Signed-off-by: nitinn <nitinn@qti.qualcomm.com>
e1fe9e8 to
79aee01
Compare
This test suite provides comprehensive validation of camera functionality using GStreamer with Qualcomm's qtiqmmfsrc plugin (downstream) or libcamerasrc (upstream). Tests run in a specific sequence to validate different camera capabilities progressively.
The test suite automatically detects which camera source plugin is available:
qtiqmmfsrc (Qualcomm CAMX downstream): Runs 10 tests
libcamerasrc (upstream): Runs 7 tests
Lava job for reference with these changes, Refer https://lava.infra.foundries.io/scheduler/job/182439#L2523