Repository navigation
either_build: absorb a term shared by both sides - #139
Merged
Merged
Conversation
…p) is x`n
A call that holds in � && b or in � && !b holds in � whatever � is, so
the route label showed the redundant build condition, e.g.
(p ? && q ? || !p ? && q ?) && !p ?
where the condition is simply q ? && !p ?. absorbed_build drops the
term the two sides differ by, when the other terms match on both sides;
opposite terms still make every build as before.
Tests: either_build pins the simplified forms and the unchanged
non-matching ones; the route label in test_a_build_that_is_a_union_of_conjunctions
is now
eeds $if q ? && !p ?. The either_build assertion failed on master
before the change.
Co-Authored-By: WOZCODE <contact@withwoz.com>
Owner
Author
Correction for the squash commit 0cb6182 (PR #139), not applied to masterThe commit on master keeps its damaged message. This note holds the intended text, Title (intended): Body (intended): Known damage on master (0cb6182): stray |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
either_buildleft a redundant build condition in route labels.(p && q) || (!p && q)isq, but the label showed the unsimplified form, e.g.needs $if (p ? && q ? || !p ? && q ?) && !p ?whereq ? && !p ?is meant.absorbed_builddrops the term the two sides differ by, when the other terms match on both sides. Opposite terms still make every build, as before.Tests:
either_buildpins the simplified forms and the unchanged non-matching ones. The new assertion failed before the change.test_a_build_that_is_a_union_of_conjunctionsnow readsneeds $if q ? && !p ?.🧙 Built with WOZCODE