fix(celltypist): model-qualify predict output filenames#34
Merged
Marius1311 merged 1 commit intoJun 26, 2026
Merged
Conversation
`cta crosscheck celltypist predict` wrote celltypist_pred_<level>.csv and celltypist_cluster_summary_<level>.csv keyed only by level, so predicting a second model at the same level (e.g. Immune_All_Low then Immune_All_High to break a tie — a recommended path) silently overwrote the first model's outputs. Interpolate safe_cluster_id(model) into both filenames, matching the sibling `markers` command (celltypist_model_markers_<model>.csv). No code reads the old names, so there's no downstream coupling. Fixes #33 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Marius1311
force-pushed
the
fix/celltypist-predict-model-qualified-filenames
branch
from
ee29eb2 to
ef95ff3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
cta crosscheck celltypist predictkeyed its two outputs only bylevel:So predicting a second model at the same level —
Immune_All_LowthenImmune_All_Highto break a tie, a path the skill explicitly recommends — silently overwrote the first model's predictions and cluster summary. No warning.Fix
Interpolate
safe_cluster_id(model)into both filenames, exactly as the siblingmarkerscommand already does (celltypist_model_markers_<model>.csv):celltypist_pred_<level>_<model>.csvcelltypist_cluster_summary_<level>_<model>.csvA repo-wide grep confirms nothing in
src/reads the old names (only the human consumes these evidence tables), so there is no downstream coupling to update.Test
pytest tests/test_smoke.py tests/test_registry_sync.py→ 7 passed.safe_cluster_id('Immune_All_Low')→Immune_All_Low.Fixes #33
🤖 Generated with Claude Code