fix(local): pass the migration error as a logging format arg

[Anai-Guo]

Problem

qdrant_client/local/persistence.py, in the dbm → sqlite migration path:

except Exception as e:
    logging.error("Failed to migrate dbm to sqlite:", e)

The message has no % placeholder, so logging treats e as a stray %-format argument and record.getMessage() raises. logging catches that internally and prints a --- Logging error --- traceback instead of the message — so the one line naming what actually failed is replaced by noise, exactly when a user's local storage is failing to migrate.

Reproduced on Python 3.12 with a ValueError("disk image is malformed"):

# before
--- Logging error ---
Traceback (most recent call last):
  ...
    msg = msg % self.args
TypeError: not all arguments converted during string formatting
Message: 'Failed to migrate dbm to sqlite:'
Arguments: (ValueError('disk image is malformed'),)

# after
ERROR Failed to migrate dbm to sqlite: disk image is malformed

Fix

Add the %s placeholder so the exception is interpolated instead of being passed as an unused argument. One character of behaviour change; the following logging.error(...) and the raise e are untouched, so control flow is identical.

I scanned the rest of qdrant_client for the same shape (logger.<level> with a constant message whose placeholder count doesn't match the number of positional args) — this is the only occurrence.

Note, not addressed here

While reading this function: if the migration raises after sqlite3.connect(str(sql_path)) has created the file, a partially-populated storage.sqlite is left on disk. The next call then hits if sql_path.exists(): return at the top and skips migration silently, so the remaining points in storage.dbm are never carried over. Whether to unlink the partial file, migrate to a temp path and rename, or leave it as-is is a maintainer call, so I left it out of this PR — happy to open a separate issue if it's worth tracking.

Branched from dev per CONTRIBUTING.

🤖 Generated with Claude Code

[netlify]

✅ Deploy Preview for poetic-froyo-8baba7 ready!

Name	Link
🔨 Latest commit	fe35c74
🔍 Latest deploy log	https://app.netlify.com/projects/poetic-froyo-8baba7/deploys/6a7d4b8972603400088c238d
😎 Deploy Preview	https://deploy-preview-1335--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 063dc063-a35d-4036-8321-69db3f2bc0af

📥 Commits

Reviewing files that changed from the base of the PR and between f003e6c and fe35c74.

📒 Files selected for processing (1)

• qdrant_client/local/persistence.py

---

📝 Walkthrough

Walkthrough

The migration failure log now passes the caught exception to the logging API as a %s formatting argument.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Mergeability Score: ⚪ Minimal · up to fe35c

This localized change only fixes error reporting during migration without changing control flow; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the logging fix in the migration error path.
Description check	✅ Passed	The description directly explains the logging problem, the fix, unchanged control flow, and the excluded migration issue.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}