feat(client): expose a closed property on the client facades

[Aryan-Pardeshi]

Closes #1299.

QdrantRemote, AsyncQdrantRemote, QdrantLocal and AsyncQdrantLocal all expose a closed property, but the two facade classes did not. close() is public on the facade, so the only way to ask whether it had been called was client._client.closed, which reaches through a private attribute to get at a public one.

>>> client = QdrantClient(":memory:")
>>> client.closed
False
>>> client.close()
>>> client.closed
True

The property forwards straight to the inner client, so there is no second source of truth to drift.

Generated file

No generator change was needed here. closed isn't on AsyncQdrantBase, so the transformer leaves it sync in the async mirror, which is what a property has to be. I ran the generator to confirm rather than assume, and its output matches what's committed.

Tests

tests/test_closed.py covers :memory:, path= and remote, sync and async, before and after close(), plus one case asserting the facade agrees with the inner client. All six fail with AttributeError: 'QdrantClient' object has no attribute 'closed' before the change.

The remote cases pass check_compatibility=False so they don't need a server on localhost.

Note on #1300

I saw that #1300 covered this issue and was closed by its author before review. This is an independent implementation, written against the current master. Happy to close mine instead if that one is coming back.

[netlify]

✅ Deploy Preview for poetic-froyo-8baba7 ready!

Name	Link
🔨 Latest commit	160b140
🔍 Latest deploy log	https://app.netlify.com/projects/poetic-froyo-8baba7/deploys/6a7a329291ab7200075ba05f
😎 Deploy Preview	https://deploy-preview-1331--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[coderabbitai]

📝 Walkthrough

Walkthrough

Added public closed properties to QdrantClient and AsyncQdrantClient. Each property delegates to the underlying client. Added synchronous and asynchronous tests for local, persistent local, and remote configurations before and after closing.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• qdrant/qdrant-client#1286: Adds related lifecycle-state behavior to the client facades.
• qdrant/qdrant-client#1300: Adds the same facade properties and corresponding tests.
• qdrant/qdrant-client#1329: Covers related client lifecycle and cleanup behavior.

Suggested reviewers: joein

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The implementation adds synchronous closed properties to both facades and tests the required states and supported client modes [#1299].
Out of Scope Changes check	✅ Passed	The changes are limited to the two facade properties and focused tests required by the linked issue.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title clearly and concisely describes exposing the closed property on both client facades.
Description check	✅ Passed	The description directly explains the closed property, implementation, compatibility, tests, and supported client modes.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/test_closed.py`:
- Around line 39-53: Add a test alongside
test_async_local_client_reports_closed_state that constructs AsyncQdrantClient
with a persistent local path, asserts closed is False before awaiting close(),
then asserts closed is True afterward.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 74d2da97-798b-4c13-a976-8496641e4a33

📥 Commits

Reviewing files that changed from the base of the PR and between 550484d and 160b140.

📒 Files selected for processing (3)

• qdrant_client/async_qdrant_client.py
• qdrant_client/qdrant_client.py
• tests/test_closed.py

[coderabbitai]

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Add asynchronous persistent-local coverage.

The tests cover AsyncQdrantClient in memory and remote modes, but not with path=.... Add the before-and-after await client.close() assertions for an asynchronous persistent-local client.

Proposed test

 `@pytest.mark.asyncio`
 async def test_async_local_client_reports_closed_state():
     client = AsyncQdrantClient(":memory:")
     assert client.closed is False
 
     await client.close()
     assert client.closed is True
 
+@pytest.mark.asyncio
+async def test_async_persistent_local_client_reports_closed_state(tmp_path):
+    client = AsyncQdrantClient(path=str(tmp_path / "storage"))
+    assert client.closed is False
+
+    await client.close()
+    assert client.closed is True
+
 `@pytest.mark.asyncio`
 async def test_async_remote_client_reports_closed_state():

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	async def test_async_local_client_reports_closed_state():
	client = AsyncQdrantClient(":memory:")
	assert client.closed is False
	await client.close()
	assert client.closed is True
	@pytest.mark.asyncio
	async def test_async_remote_client_reports_closed_state():
	client = AsyncQdrantClient("localhost", port=6333, check_compatibility=False)
	assert client.closed is False
	await client.close()
	assert client.closed is True
	async def test_async_local_client_reports_closed_state():
	client = AsyncQdrantClient(":memory:")
	assert client.closed is False
	await client.close()
	assert client.closed is True
	`@pytest.mark.asyncio`
	async def test_async_persistent_local_client_reports_closed_state(tmp_path):
	client = AsyncQdrantClient(path=str(tmp_path / "storage"))
	assert client.closed is False
	await client.close()
	assert client.closed is True
	`@pytest.mark.asyncio`
	async def test_async_remote_client_reports_closed_state():
	client = AsyncQdrantClient("localhost", port=6333, check_compatibility=False)
	assert client.closed is False
	await client.close()
	assert client.closed is True

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/test_closed.py` around lines 39 - 53, Add a test alongside
test_async_local_client_reports_closed_state that constructs AsyncQdrantClient
with a persistent local path, asserts closed is False before awaiting close(),
then asserts closed is True afterward.

[Aryan-Pardeshi]

Closing in favour of #1348 — same change, branched cleanly off dev. This one came off master, which this repo doesn't take PRs against, and showed as conflicting once retargeted.