fix: swap swapped NGS/proteomics raw data download filenames - #1485
Merged
Conversation
- NGS tab now produces <date>_<project>_ngs_measurement_dataset_locations.txt - PxP tab now produces <date>_<project>_proteomics_measurement_dataset_locations.txt Fixes #1444
1 task
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1444 — The
url.txtdownload filename was hardcoded with the wrong suffix for NGS and proteomics tabs.Problem
When downloading
url.txtfrom the raw data view, the file names were swapped:<date>_<project>_proteomics_measurement_dataset_locations.txt❌<date>_<project>_ngs_measurement_dataset_locations.txt❌Fix
Swapped the filenames so they match the selected tab:
<date>_<project>_ngs_measurement_dataset_locations.txt✅<date>_<project>_proteomics_measurement_dataset_locations.txt✅Changes
datamanager-app/src/main/java/life/qbic/datamanager/views/projects/project/rawdata/RawDataDetailsComponent.javaType
Bug fix — filename swap in
RawDataDetailsComponent.addNgsTab()andaddPxpTab().