Skip to content

Upgrade dependencies - #1366

Merged
KochTobi merged 1 commit into
mainfrom
hotfix/upgrade-dependencies
Jan 13, 2026
Merged

Upgrade dependencies#1366
KochTobi merged 1 commit into
mainfrom
hotfix/upgrade-dependencies

Conversation

@KochTobi

@KochTobi KochTobi commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

@KochTobi
KochTobi requested a review from a team January 8, 2026 09:02
@github-actions github-actions Bot added the fix label Jan 8, 2026

@sven1103 sven1103 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @KochTobi one comment i kindly would like a short feedback

Comment thread pom.xml
<groupId>dev.sigstore</groupId>
<artifactId>sigstore-maven-plugin</artifactId>
<version>1.3.0</version>
<version>2.0.0</version>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a major version jump, can you verify that the build of sigstore files works still properly?

@KochTobi KochTobi Jan 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes Sigstore files were created. .pom.sigstore.json and .jar.sigstore.json

@sven1103 sven1103 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My previous comment is obsolete, i verified locally and the Sigstore files are still created properly for every JAR and POM file.

@KochTobi
KochTobi merged commit d738561 into main Jan 13, 2026
10 of 11 checks passed
@KochTobi
KochTobi deleted the hotfix/upgrade-dependencies branch February 4, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants