Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23387
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unclassified FailureAs of commit 8bdd47d with merge base 0b3d26d ( NEW FAILURE - The following job has failed:
UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
Summary:
Add the native parser the Core AI runtime uses to read the delegate manifest,
and build and run the backend's host tests in the Core AI workflow.
- Runtime (`runtime/coreai_assets.{h,mm}`): parse and validate the manifest
for `inline` source and `aot_compiled_inline` assets, including the ordered
I/O names, file sizes and bundle digests, and select AOT assets by exact
platform and Core AI architecture match with no fallback.
- Tests: a Foundation-only `coreai_host_test` GoogleTest executable (no Swift,
no Core AI SDK) for the parser and asset selection. Path and file-map checks
are covered because they feed filesystem writes; the manifest is otherwise
treated as trusted exporter output.
- README: the "Runtime" manifest description, AOT architecture selection and
"Host Tests".
Changes outside `backends/apple/coreai` are CMake and CI only, and nothing
changes unless `EXECUTORCH_BUILD_COREAI=ON`:
- `tools/cmake/preset/default.cmake`: add `EXECUTORCH_BUILD_COREAI`
(default OFF).
- `CMakeLists.txt`: add the backend subdirectory under that option. The host
test is registered inside the backend when `EXECUTORCH_BUILD_TESTS=ON`.
- `.github/workflows/coreai.yml`: build the backend directory for macOS 27 and
run every CTest test it registers.
Test Plan:
```
# Local: configure and build only
cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=Release \
-DCMAKE_OSX_DEPLOYMENT_TARGET=27.0 -DEXECUTORCH_BUILD_COREAI=ON \
-DEXECUTORCH_BUILD_TESTS=ON -DEXECUTORCH_BUILD_EXTENSION_DATA_LOADER=ON
cmake --build build --target backends/apple/coreai/all
# CI (macOS 27 runner, .github/workflows/coreai.yml)
ctest --test-dir build/backends/apple/coreai --output-on-failure --no-tests=error
```
CTest runs `coreai_host_test`.
metascroy
force-pushed
the
coreai-v2/01-export-parser
branch
from
October 5, 2026 03:14
0485975 to
8bdd47d
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the native parser the Core AI runtime uses to read the delegate manifest, and builds and runs the backend's host tests in the Core AI workflow. This is the first of the runtime PRs; it does not add an ExecuTorch delegate yet.
runtime/coreai_assets.{h,mm}):inlinesource andaot_compiled_inlineassets:function, orderedinput_names/output_names, thefilessize map andbundle_digests.coreai_host_testGoogleTest executable (no Swift, no Core AI SDK) for the parser and asset selection. Path and file-map checks are covered because they feed filesystem writes; the manifest is otherwise treated as trusted exporter output.backends/apple/coreai/.clang-format: the root style without itsLanguage: Cppkey, so clang-format also formats the backend's Objective-C headers.backends/apple/coreaiare CMake and CI only, and nothing changes unlessEXECUTORCH_BUILD_COREAI=ON:tools/cmake/preset/default.cmake: addEXECUTORCH_BUILD_COREAI(default OFF).CMakeLists.txt: add the backend subdirectory under that option..github/workflows/coreai.yml: buildbackends/apple/coreai/allfor macOS 27 with tests on, and run every CTest test the backend registers (--no-tests=error).Stack: 1 of 9 Core AI runtime PRs, based on
main. Next: #23388.Test plan: built locally for macOS 27.0 (
backends/apple/coreai/all,EXECUTORCH_BUILD_TESTS=ON);ctest -Nlistscoreai_host_test, which the Core AI workflow runs on the macOS 27 runner.lintrunneris clean.