Skip to content

Move targets.bzl to proper location - #21495

Merged
bigfootjon merged 2 commits into
mainfrom
targets2buck/adjust-targets.bzl-location
Jul 31, 2026
Merged

Move targets.bzl to proper location#21495
bigfootjon merged 2 commits into
mainfrom
targets2buck/adjust-targets.bzl-location

Conversation

@bigfootjon

Copy link
Copy Markdown
Member

This enables #21429 to work correctly (see failing BUCK CI job there)

It's currently failing due to targets.bzl being exported from Meta to the wrong location. This fixes that on GH.

Copilot AI review requested due to automatic review settings July 30, 2026 16:04
@pytorch-bot

pytorch-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21495

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job

As of commit 16b438e with merge base 4e285f4 (image):

NEW FAILURE - The following job has failed:

  • pull / android / run-emulator (gh)
    Warning: An error occurred while preparing SDK package Android Emulator: https://dl.google.com/android/repository/emulator-linux_x64-15917651.zip.

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 30, 2026
@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings July 30, 2026 16:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Ready to approve

The functional changes are small and align the Buck load paths with the configured fbsource cell mapping, with only minor documentation clarity nits.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Review details

Comments suppressed due to low confidence (1)

runtime/core/BUCK:4

  • The header comment says shared targets must be defined in a local targets.bzl, but this BUCK file now loads them from @fbsource//xplat/executorch/runtime/core:targets.bzl (shim_et cell). Updating the comment would reduce confusion when someone goes looking for runtime/core/targets.bzl in OSS.
# Any targets that should be shared between fbcode and xplat must be defined in
# targets.bzl. This file can contain xplat-only targets.

load("@fbsource//xplat/executorch/runtime/core:targets.bzl", "define_common_targets")
  • Files reviewed: 1/2 changed files
  • Comments generated: 0 new
  • Review effort level: Low

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

@bigfootjon
bigfootjon merged commit d8c6be2 into main Jul 31, 2026
188 of 190 checks passed
@bigfootjon
bigfootjon deleted the targets2buck/adjust-targets.bzl-location branch July 31, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants