Move targets.bzl to proper location - #21495
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21495
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled JobAs of commit 16b438e with merge base 4e285f4 ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
🟢 Ready to approve
The functional changes are small and align the Buck load paths with the configured fbsource cell mapping, with only minor documentation clarity nits.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Review details
Comments suppressed due to low confidence (1)
runtime/core/BUCK:4
- The header comment says shared targets must be defined in a local
targets.bzl, but this BUCK file now loads them from@fbsource//xplat/executorch/runtime/core:targets.bzl(shim_et cell). Updating the comment would reduce confusion when someone goes looking forruntime/core/targets.bzlin OSS.
# Any targets that should be shared between fbcode and xplat must be defined in
# targets.bzl. This file can contain xplat-only targets.
load("@fbsource//xplat/executorch/runtime/core:targets.bzl", "define_common_targets")
- Files reviewed: 1/2 changed files
- Comments generated: 0 new
- Review effort level: Low
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
This enables #21429 to work correctly (see failing BUCK CI job there)
It's currently failing due to
targets.bzlbeing exported from Meta to the wrong location. This fixes that on GH.