force neon vectorization for ios (#21479) - #21479
Open
JakeStevens wants to merge 2 commits into
Open
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21479
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled JobAs of commit e3b5b27 with merge base d632341 ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113940046. |
This PR needs a
|
meta-codesync
Bot
changed the title
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Jul 30, 2026
Summary: The default implementation auto-vectorized well for Android builds, but the specific LLVM Clang 21 toolchain + compiler flags did not auto-vectorize, resulting in only scalar operations. This commit selectively forces neon vectorization for iOS Differential Revision: D113940046
JakeStevens
force-pushed
the
export-D113940046
branch
from
July 30, 2026 00:03
530ec25 to
57e01dc
Compare
Summary: Adds separate query-head and state-head configuration to the model definition as well as updates the fused channelwise_gated_delta_rule custom op to support grouped decode and prefill. Reviewed By: YIWENX14 Differential Revision: D113299906
Summary: The default implementation auto-vectorized well for Android builds, but the specific LLVM Clang 21 toolchain + compiler flags did not auto-vectorize, resulting in only scalar operations. This commit selectively forces neon vectorization for iOS Reviewed By: YIWENX14 Differential Revision: D113940046
JakeStevens
force-pushed
the
export-D113940046
branch
from
July 30, 2026 18:50
57e01dc to
e3b5b27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The default implementation auto-vectorized well for Android builds, but the specific LLVM Clang 21 toolchain + compiler flags did not auto-vectorize, resulting in only scalar operations.
This commit selectively forces neon vectorization for iOS
Reviewed By: YIWENX14
Differential Revision: D113940046