Repository navigation
Fix minGPT multi-node GPU count check - #1428
Open
daksheshsharma2409 wants to merge 1 commit into
Open
daksheshsharma2409 wants to merge 1 commit into
daksheshsharma2409 wants to merge 1 commit into
Conversation
✅ Deploy Preview for pytorch-examples-preview canceled.
|
1 similar comment
✅ Deploy Preview for pytorch-examples-preview canceled.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1395
Description
Use
LOCAL_WORLD_SIZEto determine the minimum number of local accelerators required by the minGPT DDP example. This allows multi-node configurations with one GPU per node while still checking that each node has enough local devices for its workers.I used Claude to help investigate the issue and reason about the proposed change. I reviewed the implementation and performed the validation checks listed below.
Validation
git diff --checkpython3 -m py_compile distributed/minGPT-ddp/mingpt/main.py