Skip to content

Rename discriminator score variables for clarity - #1427

Open
Venkatasai200628 wants to merge 1 commit into
pytorch:mainfrom
Venkatasai200628:Venkatasai200628-patch-1
Open

Venkatasai200628 wants to merge 1 commit into
pytorch:mainfrom
Venkatasai200628:Venkatasai200628-patch-1

Conversation

@Venkatasai200628

Copy link
Copy Markdown

This PR improves readability in the DCGAN example by replacing the abbreviated D_G_z1 and D_G_z2 variable names with descriptive names.

The training calculations and printed output format are unchanged.

Closes #487

@meta-cla

meta-cla Bot commented Oct 18, 2026

Copy link
Copy Markdown

Hi @Venkatasai200628!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify

netlify Bot commented Oct 18, 2026

Copy link
Copy Markdown

👷 Deploy Preview for pytorch-examples-preview processing.

Name Link
🔨 Latest commit 965076d
🔍 Latest deploy log https://app.netlify.com/projects/pytorch-examples-preview/deploys/6ad530ec0e2686c05d9dd488

@netlify

netlify Bot commented Oct 18, 2026

Copy link
Copy Markdown

✅ Deploy Preview for pytorch-examples-preview canceled.

Name Link
🔨 Latest commit 965076d
🔍 Latest deploy log https://app.netlify.com/projects/pytorch-examples-preview/deploys/6ad530ec0e2686c05d9dd488

@meta-cla

meta-cla Bot commented Oct 18, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the cla signed label Oct 18, 2026
@Venkatasai200628

Copy link
Copy Markdown
Author

Hi maintainers, gentle ping on this one when you have a moment. It's a small readability change to the DCGAN example (renaming D_G_z1/D_G_z2 to descriptive names, no change to training or output) and closes #487. The CI checks are waiting on workflow approval. Happy to make any changes you'd like. Thanks!

@Venkatasai200628
Venkatasai200628 marked this pull request as draft October 26, 2026 08:54
@Venkatasai200628
Venkatasai200628 marked this pull request as ready for review October 26, 2026 08:55

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

please use longer names for variables than 2-3 letter acronyms

1 participant