Repository navigation
Keep asymmetric int8 correction in higher precision - #5035
adityuhkapoor wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/5035
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @adityuhkapoor! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Apply the activation zero-point correction before narrowing, promoting scales to at least FP32. Preserve FP64 scales and symmetric rounding; add bias before the corrected path's final cast.
All 57 CPU/CUDA eager and full-graph regression cases pass with PyTorch 2.14.1 on an H100 host. In two-shape H100 microbenchmarks, observed asymmetric latency changes were within 2% in eager mode and -6.2% to +6.4% compiled.
Fixes #5026.