Skip to content

Keep asymmetric int8 correction in higher precision - #5035

Open
adityuhkapoor wants to merge 1 commit into
pytorch:mainfrom
adityuhkapoor:fix/int8-asymmetric-correction-precision
Open

adityuhkapoor wants to merge 1 commit into
pytorch:mainfrom
adityuhkapoor:fix/int8-asymmetric-correction-precision

Conversation

@adityuhkapoor

Copy link
Copy Markdown

Apply the activation zero-point correction before narrowing, promoting scales to at least FP32. Preserve FP64 scales and symmetric rounding; add bias before the corrected path's final cast.

All 57 CPU/CUDA eager and full-graph regression cases pass with PyTorch 2.14.1 on an H100 host. In two-shape H100 microbenchmarks, observed asymmetric latency changes were within 2% in eager mode and -6.2% to +6.4% compiled.

Fixes #5026.

@pytorch-bot

pytorch-bot Bot commented Oct 29, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/5035

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla

meta-cla Bot commented Oct 29, 2026

Copy link
Copy Markdown

Hi @adityuhkapoor!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla

meta-cla Bot commented Oct 30, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 30, 2026
@meta-cla

meta-cla Bot commented Oct 30, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

1 participant