Repository navigation
Conversation
Compose.__signature__ only needs the last function for the return annotation, but called inspect.signature on it unguarded. For builtins like max or set this raised ValueError, so inspect.signature(compose(max, f)) failed even though f has a normal signature. Fall back to no return annotation in that case.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inspect.signature(compose(max, f))raisesValueError: no signature found for builtin maxeven thoughfhas a perfectly good signature.Compose.__signature__only uses the last function for the return annotation, so I wrapped that lookup in a try/except and fall back to no return annotation.I added a test that uses
maxas the last function. It fails before the change and passes after, and the existing tests still pass.