Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partition_all(0, rows)and negative sizes silently produce an empty iterator even with nonempty input. A valid integer-index object is accepted when the iterator group is built, but can raiseTypeErrorlater when a short final batch requires arithmetic on the original object.Normalize the batch size once using
operator.indexand require it to be positive before touching the source. Document the requirement and test empty/nonempty inputs, unchanged source consumption on invalid size, and an indexable size with a short final batch.Validation: three regressions fail against the original code; the library and doctest suite passes with the fix (271 passed, 2 skipped). Configured pycodestyle and
git diff --checkpass. Nonpositive sizes now raiseValueErrorwhen the generator is advanced; non-integral sizes remainTypeError.