Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NumPy arrays cannot be used as
get/pluckdefaults,reducebyinitial vectors, or outerjoindefaults: comparing them directly with the sentinel string produces an array and raises the ambiguous-truth-value error. These are useful defaults when looking up or aggregating vector data.Restrict the sentinel equality check to strings and
UserStringvalues. Keep the existing behavior for the mangled__no__default__string, including copies, while returning non-string defaults without invoking their equality operator. Add regressions for each affected API andUserStringcompatibility controls.This preserves the compatibility behavior discussed in #625. Related #643 addresses
accumulate; the changed functions here do not overlap it.Validation: four NumPy regressions fail on unchanged master; the complete suite passes after the fix (198 tests with NumPy enabled). Pyflakes and line-length checks pass. NumPy is an optional test dependency, not a runtime dependency.