Show error message instead of 500 when downloading certificate without a layout exists - #7
Open
et15 wants to merge 1 commit into
Open
Show error message instead of 500 when downloading certificate without a layout exists#7et15 wants to merge 1 commit into
et15 wants to merge 1 commit into
Conversation
…t a layout DownloadCertificateView.get() called render_certificate() without catching AttendanceCertificateLayout.DoesNotExist, causing an unhandled 500 when an event has no certificate layout configured yet. Now shows a control-panel error message and redirects back to the order, matching the pattern already used in SendCertificateView.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DownloadCertificateView.get() called render_certificate() without catching AttendanceCertificateLayout.DoesNotExist, causing an unhandled 500 when an event has no certificate layout configured yet. Now shows a control-panel error message and redirects back to the order, matching the pattern already used in SendCertificateView.
Why
To avoid server errors when trying to download certificates with non-existent layouts and tell the user what to do instead.