Allow error on incorrect implicit argument to zero-argument super()#2253
Open
carljm wants to merge 1 commit intopython:mainfrom
Open
Allow error on incorrect implicit argument to zero-argument super()#2253carljm wants to merge 1 commit intopython:mainfrom
carljm wants to merge 1 commit intopython:mainfrom
Conversation
AlexWaygood
reviewed
Apr 8, 2026
| class Meta3(type): | ||
| def __call__(cls: type[T], *args, **kwargs) -> T: | ||
| return super().__call__(*args, **kwargs) | ||
| return super().__call__(*args, **kwargs) # E?: type[T] is not an instance or subclass of `Meta3` |
Member
There was a problem hiding this comment.
This file isn't really making any assertions about support for super() at all -- it's making assertions about how type checkers should interpret constructor calls. So we could sidestep the issue of zero-argument-super() entirely here:
Suggested change
| return super().__call__(*args, **kwargs) # E?: type[T] is not an instance or subclass of `Meta3` | |
| return type.__call__(cls, *args, **kwargs) |
All type checkers appear to be happy if you make that change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The full rationale for this PR is explained at https://discuss.python.org/t/cls-type-t-and-super/106893