Skip to content

bpo-40837: Fix email.utils.encode_rfc2231(string, None, None)#20564

Open
spaceone wants to merge 1 commit intopython:mainfrom
spaceone:master
Open

bpo-40837: Fix email.utils.encode_rfc2231(string, None, None)#20564
spaceone wants to merge 1 commit intopython:mainfrom
spaceone:master

Conversation

@spaceone
Copy link
Copy Markdown

@spaceone spaceone commented Jun 1, 2020

encode_rfc2231() must not change the returned value if no transformation of the input was done.
This is also mentioned in the docstring of that function.

Actual behavior:

encode_rfc2231('foo bar', None, None)
'foo%20bar'

Expected behavior:

encode_rfc2231('foo bar', None, None)
'foo bar'

https://bugs.python.org/issue40837

@spaceone spaceone requested a review from a team as a code owner June 1, 2020 02:16
@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@spaceone

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@spaceone spaceone changed the title Fix email.utils.encode_rfc2231(string, None, None) bpo40837: Fix email.utils.encode_rfc2231(string, None, None) Jun 1, 2020
@orsenthil
Copy link
Copy Markdown
Member

@spaceone , please sign the CLA and we will need a bugs.python.org issue number.
I worry about the clients that rely on the existing behavior.

@spaceone
Copy link
Copy Markdown
Author

spaceone commented Jun 3, 2020

@spaceone , please sign the CLA and we will need a bugs.python.org issue number.
I worry about the clients that rely on the existing behavior.
I already signed the CLA and updated the bug number in the issue description. The bot doesn't update the status. I will add the bug number to the commit message as well.

@spaceone spaceone changed the title bpo40837: Fix email.utils.encode_rfc2231(string, None, None) bpo-40837: Fix email.utils.encode_rfc2231(string, None, None) Jun 3, 2020
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Apr 8, 2026
@spaceone
Copy link
Copy Markdown
Author

spaceone commented Apr 8, 2026

@ezio-melotti why did you remove the CLA Signed label?

@spaceone
Copy link
Copy Markdown
Author

spaceone commented Apr 8, 2026

This PR is stale because it has been open for 30 days with no activity.

jeah, lol. No merge since 6 years.

encode_rfc2231() must not change the returned value if no transformation of the input was done.
This is also mentioned in the docstring of that function.

Actual behavior:
encode_rfc2231('foo bar', None, None)
'foo%20bar'

Expected behavior:
encode_rfc2231('foo bar', None, None)
'foo bar'
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Apr 8, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core review stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants