Repository navigation
Conversation
pyport.h uses _Py_STDC_VERSION to select _Py_thread_local, _Py_NULL and _Py_TYPEOF, but the macro was defined in pymacro.h, which Python.h includes after pyport.h. The C11 and C23 branches were therefore never taken. Move the definition to pyport.h. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
hello @skdas20, can i help with unsuccessful test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyport.huses_Py_STDC_VERSIONto pick_Py_thread_local,_Py_NULLand_Py_TYPEOF, but the macro is defined inpymacro.h, whichPython.hincludes afterpyport.h. So those C11/C23 branches are never taken. This moves the definition intopyport.h.Macro values with
#include "Python.h"(cc -E -dM):-std=c11_Py_thread_local__thread_Thread_local-std=c23_Py_NULLNULLnullptr-std=c23_Py_TYPEOF(expr)__typeof__(expr)typeof(expr)./python -m test test_cext -u cpupasses on Linux (the MSVC-only test is skipped).This doesn't touch the inverted
static_assertfallback condition inpymacro.h, which gh-160705 already fixes._Py_STDC_VERSIONmacro not available in pyport.h #160719🤖 Generated with Claude Code