gh-153568: Reduce parser allocations - #157374
Open
pablogsal wants to merge 7 commits into
Open
Conversation
pablogsal
force-pushed
the
gh-153568-parser-allocations
branch
from
September 12, 2026 22:46
9f8c9c0 to
0cd6ee2
Compare
Member
Author
|
This looks gigantic because the parser autogenerated changes but it's quite tiny :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allocate tokens in blocks and keep text only for names, literals and type comments. Use a bit for the Barry spelling and put the keyword error messages in the grammar. Create the identifier cache on first use and reuse the newline buffer. Reuse parsed names and numbers during backtracking, and reset memo filters before the error pass.
Related to #153568.