Skip to content

gh-157265: Adjust test for Windows - #157334

Merged
encukou merged 1 commit into
python:mainfrom
encukou:gh-157266-windows-fix
Sep 11, 2026
Merged

gh-157265: Adjust test for Windows#157334
encukou merged 1 commit into
python:mainfrom
encukou:gh-157266-windows-fix

Conversation

@encukou

@encukou encukou commented Sep 11, 2026

Copy link
Copy Markdown
Member

On my Windows box (without developer mode), the behaviour is the same as without the fix in GH-157266:

  • a/t/dummy is extracted
  • b/ is extracted
  • c/ is not created (the target, a/t, is not in the archive)
  • c/escape: c/ is created; escape is skipped (target, c/../../link_here, is not in archive)
  • c is not recreated as a directory
  • boom is not created (target is c/escape, which falls back to ../../link_here, which does not exist in archive)

On Windows (no symlinks, no hardlinks), the behaviour is
the same as without the fix in pythonGH-157266:
- a/t/dummy is extracted
- b/ is extracted
- c/ is *not* created (the target, a/t, is not in the archive)
- c/escape: c/ is created; escape is skipped (target,
   c/../../link_here, is not in archive)
- c is not recreated as a directory
- boom is not created (target is c/escape, which falls back to
  ..\..\link_here, which does not exist in archive)
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels Sep 11, 2026
@encukou encukou changed the title gh-157266: Adjust test for Windows gh-157265: Adjust test for Windows Sep 11, 2026
@encukou

encukou commented Sep 11, 2026

Copy link
Copy Markdown
Member Author

!buildbot Windows

@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 7d81259 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F157334%2Fmerge

The command will test the builders whose names match following regular expression: Windows

The builders matched are:

  • AMD64 Windows PGO Tailcall PR
  • AMD64 Windows11 Non-Debug PR
  • AMD64 Windows Server 2025 Refleaks PR
  • AMD64 Windows Server 2025 Clang PR
  • AMD64 Windows Server 2022 NoGIL PR
  • AMD64 Windows PGO NoGIL Tailcall PR
  • ARM64 Windows PR
  • ARM64 Windows Non-Debug PR
  • AMD64 Windows10 PR
  • AMD64 Windows PGO PR
  • AMD64 Windows PGO NoGIL PR

@encukou

encukou commented Sep 11, 2026

Copy link
Copy Markdown
Member Author

Merging without review to unblock buildbots.

@encukou
encukou merged commit d9565e5 into python:main Sep 11, 2026
59 of 63 checks passed
@encukou
encukou deleted the gh-157266-windows-fix branch September 11, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants