[3.14] gh-156939: Fix xmlcharrefreplace() buffer overflow (GH-157109) - #157233
Open
miss-islington wants to merge 2 commits into
Open
[3.14] gh-156939: Fix xmlcharrefreplace() buffer overflow (GH-157109)#157233miss-islington wants to merge 2 commits into
miss-islington wants to merge 2 commits into
Conversation
vstinner
enabled auto-merge (squash)
September 9, 2026 19:19
StanFromIreland
disabled auto-merge
September 10, 2026 20:08
Member
|
@vstinner this is broken on older branches. |
Member
Oh thanks for the ping, I didn't pay attention if this backport was merged or not.
The compiler hint is correct, 3.14 uses MAX_UNICODE. I pushed a change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Write into a temporary buffer to not write the trailing NUL byte
into the writer. Previously, the NUL byte was written outsize
the writer buffer.
(cherry picked from commit 9398655)
Co-authored-by: Victor Stinner vstinner@python.org