gh-156939: Detect buffer overflow in PyBytesWriter in debug mode - #156943
Open
vstinner wants to merge 4 commits into
Open
gh-156939: Detect buffer overflow in PyBytesWriter in debug mode#156943vstinner wants to merge 4 commits into
vstinner wants to merge 4 commits into
Conversation
Member
Author
|
Oh, the test_xml_etree_c failure is a legit failure: unicode_encode_ucs1() calls with |
Member
Author
|
The test_struct error is also a legit bug: a Pascal string of 0 characters writes a NUL byte into an empty buffer, and so triggers a buffer overflow. |
Member
Author
|
On Ubuntu, 8 tests are failing: |
Reserve one byte in PyBytesWriter used as a canary byte: set it to a special value. PyBytesWriter_Finish() checks if the canary byte has been overriden. Add a test on the feature. Update buffer overflow check in fcntl: allocate extra guard bytes in the writer and then truncate these bytes.
vstinner
force-pushed
the
writer_canary
branch
from
September 9, 2026 19:38
42640e3 to
89a8ac9
Compare
Member
Author
Avoid calling PyBytesWriter_Grow().
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reserve one byte in PyBytesWriter used as a canary byte: set it to a special value. PyBytesWriter_Finish() checks if the canary byte has been overriden. Add a test on the feature.
Update buffer overflow check in fcntl: allocate extra guard bytes in the writer and then truncate these bytes.