Skip to content

gh-156568: Make zipapp archives executable with PathLike targets - #156569

Open
eoan-ermine wants to merge 4 commits into
python:mainfrom
eoan-ermine-forks:gh-156568
Open

gh-156568: Make zipapp archives executable with PathLike targets#156569
eoan-ermine wants to merge 4 commits into
python:mainfrom
eoan-ermine-forks:gh-156568

Conversation

@eoan-ermine

@eoan-ermine eoan-ermine commented Aug 29, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown

Fix zipapp.create_archive() not setting the executable bit for PathLike targets.

@python-cla-bot

python-cla-bot Bot commented Aug 29, 2026 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app Bot mentioned this pull request Aug 29, 2026
Open
@eoan-ermine

eoan-ermine commented Aug 29, 2026

Copy link
Copy Markdown
Author

@pfmoore fyi

@aisk aisk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Aug 29, 2026
pfmoore
pfmoore requested changes Aug 29, 2026
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2026-08-29-14-28-46.gh-issue-156568.mkxLY8.rst Outdated
Comment thread Lib/test/test_zipapp.py
@bedevere-app

bedevere-app Bot commented Aug 29, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

eoan-ermine and others added 2 commits August 29, 2026 21:32
@eoan-ermine @pfmoore
Update Misc/NEWS.d/next/Library/2026-08-29-14-28-46.gh-issue-156568.m…
212ae2f 
…kxLY8.rst

Co-authored-by: Paul Moore <p.f.moore@gmail.com>
@eoan-ermine @pfmoore
Clarify intention of zipapp.create_archive test
9168203 
Co-authored-by: Paul Moore <p.f.moore@gmail.com>
@eoan-ermine

eoan-ermine commented Aug 29, 2026

Copy link
Copy Markdown
Author

I have made the requested changes; please review again

@bedevere-app

bedevere-app Bot commented Aug 29, 2026

Copy link
Copy Markdown

Thanks for making the requested changes!

@pfmoore: please review the changes made to this pull request.

@bedevere-app
bedevere-app Bot requested a review from pfmoore August 29, 2026 19:00
@eoan-ermine

eoan-ermine commented Sep 4, 2026

Copy link
Copy Markdown
Author

@pfmoore Just following up on this PR — would appreciate a review when you get a chance. Thanks!

@pfmoore

pfmoore commented Sep 9, 2026

Copy link
Copy Markdown
Member

@hugovk Should I hold off on merging this as we're so close to 3.15 release (or at least hold off on the 3.15 backport)? It's not an urgent fix, so I'm personally happy to wait till 3.15 is released.

@hugovk

hugovk commented Sep 12, 2026

Copy link
Copy Markdown
Member

You can merge it to main (and 3.13/3.14) and just hold off on the 3.15 backport if you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aisk aisk aisk approved these changes
@pfmoore pfmoore pfmoore approved these changes

Assignees

No one assigned

Labels

awaiting merge needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eoan-ermine @pfmoore @hugovk @aisk