gh-149277: Fix error position for invalid numeric literals - #155534
Open
skirpichev wants to merge 8 commits into
Open
gh-149277: Fix error position for invalid numeric literals#155534skirpichev wants to merge 8 commits into
skirpichev wants to merge 8 commits into
Conversation
serhiy-storchaka
self-requested a review
September 3, 2026 11:46
pablogsal
reviewed
Sep 7, 2026
| # Errors thrown by the tokenizer | ||
| check('(0x+1)', 1, 3) | ||
| check('x = 0xI', 1, 6) | ||
| check('(0x+1)', 1, 4) |
Member
There was a problem hiding this comment.
The exponent-sign and underscore branches still back up before reporting the error. Can we update those too, or narrow the NEWS wording?
Member
Author
There was a problem hiding this comment.
Thanks, good catch. I hope now news entry is correct.
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.