Skip to content

gh-148274: Properly handle result from PyObject_VisitManagedDict #148275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maxbachmann wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-148274: Properly handle result from PyObject_VisitManagedDict #148275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c0de79
Properly handle result from PyObject_VisitManagedDict
maxbachmann Apr 8, 2026
bfaaf38
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-04-08-22-12-46.gh-issue-148274.sZbq5p.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Ensure correct handling of the result returned by :c:func:`PyObject_VisitManagedDict`
6 changes: 2 additions & 4 deletions Modules/_asynciomodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -944,8 +944,7 @@ FutureObj_traverse(PyObject *op, visitproc visit, void *arg)
Py_VISIT(fut->fut_cancel_msg);
Py_VISIT(fut->fut_cancelled_exc);
Py_VISIT(fut->fut_awaited_by);
PyObject_VisitManagedDict((PyObject *)fut, visit, arg);
return 0;
return PyObject_VisitManagedDict((PyObject *)fut, visit, arg);
}

/*[clinic input]
Expand Down Expand Up @@ -2425,8 +2424,7 @@ TaskObj_traverse(PyObject *op, visitproc visit, void *arg)
Py_VISIT(fut->fut_cancel_msg);
Py_VISIT(fut->fut_cancelled_exc);
Py_VISIT(fut->fut_awaited_by);
PyObject_VisitManagedDict((PyObject *)fut, visit, arg);
return 0;
return PyObject_VisitManagedDict((PyObject *)fut, visit, arg);
}

/*[clinic input]
Expand Down
3 changes: 1 addition & 2 deletions Modules/_testcapimodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3280,9 +3280,8 @@ typedef struct {
} ManagedDictObject;

int ManagedDict_traverse(PyObject *self, visitproc visit, void *arg) {
PyObject_VisitManagedDict(self, visit, arg);
Py_VISIT(Py_TYPE(self));
return 0;
return PyObject_VisitManagedDict(self, visit, arg);
}

int ManagedDict_clear(PyObject *self) {
Expand Down
9 changes: 3 additions & 6 deletions Objects/typevarobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,8 +500,7 @@ typevar_traverse(PyObject *self, visitproc visit, void *arg)
Py_VISIT(tv->evaluate_constraints);
Py_VISIT(tv->default_value);
Py_VISIT(tv->evaluate_default);
PyObject_VisitManagedDict(self, visit, arg);
return 0;
return PyObject_VisitManagedDict(self, visit, arg);
}

static int
Expand Down Expand Up @@ -1195,8 +1194,7 @@ paramspec_traverse(PyObject *self, visitproc visit, void *arg)
Py_VISIT(ps->bound);
Py_VISIT(ps->default_value);
Py_VISIT(ps->evaluate_default);
PyObject_VisitManagedDict(self, visit, arg);
return 0;
return PyObject_VisitManagedDict(self, visit, arg);
}

static int
Expand Down Expand Up @@ -1692,8 +1690,7 @@ typevartuple_traverse(PyObject *self, visitproc visit, void *arg)
Py_VISIT(tvt->name);
Py_VISIT(tvt->default_value);
Py_VISIT(tvt->evaluate_default);
PyObject_VisitManagedDict(self, visit, arg);
return 0;
return PyObject_VisitManagedDict(self, visit, arg);
}

static int
Expand Down
Loading