gh-148210: fix incorrect _BINARY_OP_SUBSCR_DICT JIT optimization #148213
Merged
Fidget-Spinner merged 2 commits intopython:mainfrom Apr 8, 2026
Merged
gh-148210: fix incorrect _BINARY_OP_SUBSCR_DICT JIT optimization #148213Fidget-Spinner merged 2 commits intopython:mainfrom
_BINARY_OP_SUBSCR_DICT JIT optimization #148213Fidget-Spinner merged 2 commits intopython:mainfrom
Conversation
Member
|
The fix looks correct, but can we have a test? >>> f = frozendict({"a":1})
>>> def test():
... for _ in range(10_000):
... f["a"]
>>> test()
Segmentation fault (core dumped) |
Contributor
Author
Thanks for the reproducer, I added a test based on it. |
Fidget-Spinner
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @Fidget-Spinner for suggesting the fix.
_BINARY_OP_SUBSCR_DICTis wrong. #148210