Add a compatibility shim for migrating Android build tools to Platforms#699
Open
freakboy3742 wants to merge 2 commits intopython:mainfrom
Open
Add a compatibility shim for migrating Android build tools to Platforms#699freakboy3742 wants to merge 2 commits intopython:mainfrom
freakboy3742 wants to merge 2 commits intopython:mainfrom
Conversation
vstinner
reviewed
Apr 8, 2026
| name="Set up compatibility symlink", | ||
| command=( | ||
| "[ -e Platforms/Android ]" | ||
| "|| ln -s ../Android Platforms/Android" |
Member
There was a problem hiding this comment.
On Python 3.13, this command fails with:
ln: failed to create symbolic link 'Platforms/Android': No such file or directory
You should create the Platforms/ directory somehow. For example, add [ -e Platforms ] || mkdir Platforms; prefix to your command.
Comment on lines
+1277
to
+1279
| "[ -e Platforms/Android ]" | ||
| "|| ln -s ../Android Platforms/Android" | ||
| "&& ln -si ../Android/android.py Platforms/Android/__main__.py" |
Member
There was a problem hiding this comment.
For readability, you should add spaces:
Suggested change
| "[ -e Platforms/Android ]" | |
| "|| ln -s ../Android Platforms/Android" | |
| "&& ln -si ../Android/android.py Platforms/Android/__main__.py" | |
| "[ -e Platforms/Android ] " | |
| "|| ln -s ../Android Platforms/Android " | |
| "&& ln -si ../Android/android.py Platforms/Android/__main__.py" |
mhsmith
reviewed
Apr 8, 2026
| android_py = ["python3", "Platforms/Android"] | ||
| self.addSteps([ | ||
| # This symlink is needed to support pre Python 3.15 builds - it makes the | ||
| # top level Andrdoid folder appear in the new Platforms/Android location, |
Member
There was a problem hiding this comment.
Suggested change
| # top level Andrdoid folder appear in the new Platforms/Android location, | |
| # top level Android folder appear in the new Platforms/Android location, |
Comment on lines
+1277
to
+1279
| "[ -e Platforms/Android ]" | ||
| "|| ln -s ../Android Platforms/Android" | ||
| "&& ln -si ../Android/android.py Platforms/Android/__main__.py" |
Member
There was a problem hiding this comment.
This would be much more readable as an if ... then statement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the pattern used by the iOS build, adds a compatibility shim so that the buildbot will run
Platforms/Android, but that location will work on 3.13 and 3.14 repos that store the Android build code inAndroid/android.py.Also updates the iOS configuration to use the same general pattern for invoking the build script.
As part of this, the
CACHE_DIRconfiguration has been moved out of the buildbot definition, and into the environment where the buildbot is executed. This means the buildbot configuration is no longer sensitive to the specific user account that is hosting the buildbot instance.This configuration can be landed now, without the
Platformsmigration having been made - the Android folder exists in all 3.13+ repos as of right now. Once the Platforms migration occurs the symlink step will become a no-op.