Repository navigation
Conversation
Co-authored-by: m-aciek <9288014+m-aciek@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 752c518350
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| const sortField = sortFields[sortBy] || sortFields['completion-score']; | ||
| return Number(b.dataset[sortField]) - Number(a.dataset[sortField]) || nameComparison; | ||
| return Number(b.dataset[sortField]) - Number(a.dataset[sortField]); |
There was a problem hiding this comment.
When a browser-language card has the same numeric value as surrounding cards—especially the common zero value for recent changes—reorder() removes its pinPriority while the card is still at the pinned front and then invokes this comparator. Returning zero preserves that pinned position within the tied group, so unpinning may not move the card at all and does not restore its normal position. Preserve an order from before pinning or use a deterministic tie-breaker when the pin state changes.
Useful? React with 👍 / 👎.
Keep cards with equal sort values in their existing order when switching sort criteria.
Motivation: some sort criteria apply to narrow range of projects (for example recent changes). Keeping sorting stable instead of alphabetic order for the equal weights seems more natural and obvious.
📊 Dashboard preview 📊: https://python-docs-translations.github.io/dashboard/207/merge/