fix: bytecode cache invalidation for moved test files (#14552) - #14989
Open
15r10nk wants to merge 1 commit into
Open
fix: bytecode cache invalidation for moved test files (#14552)#1498915r10nk wants to merge 1 commit into
15r10nk wants to merge 1 commit into
Conversation
psf-chronographer
Bot
added
the
bot:chronographer:provided
15r10nk
marked this pull request as ready for review
September 8, 2026 13:05
RonnyPfannschmidt
requested changes
Sep 10, 2026
RonnyPfannschmidt
left a comment
RonnyPfannschmidt
left a comment
Member
There was a problem hiding this comment.
Thanks for starting this
Unfortunately the test doesn't validate the invariant holding
| pytester.path.joinpath("test1").rename(pytester.path.joinpath("test2")) | ||
|
|
||
| second = pytester.runpytest_subprocess("-s", "test2/test_a.py") | ||
| second.assert_outcomes(passed=1) |
Member
There was a problem hiding this comment.
This test doesn't validate the invatiant
Contributor
Author
There was a problem hiding this comment.
I don't understand what is missing here for you.
- The tests fails without the fix.
- It reproduces the incorrect behaviour by moving the source and cached bytecode.
Which invariant do you mean?
Member
There was a problem hiding this comment.
The test would pass without changes when one disables bytecode writing for example
Member
There was a problem hiding this comment.
Ill show a more detailed example once I get back to the computer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves #14552