Prevent negative reruns from skipping initial test execution - #360
Merged
Conversation
icemac
approved these changes
Sep 3, 2026
Contributor
|
Thank you for this PR. 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #359.
Negative rerun counts could skip the test entirely, because the rerun limit was checked before the first run.
This change ensures that the initial test execution is never suppressed by the rerun count.
Negative values no longer produce a false success without running the test.
Regression tests cover the supported rerun configuration sources, and also the distributed StatusDB path with xdist.
I also ran some local A/B checks for non-negative rerun counts, xdist worker crashes, exclusions, and other negative values.