Repository navigation
Fix djlint findings in index.jinja2 so pre-commit passes - #1079
Open
contputer0x0 wants to merge 1 commit into
Open
contputer0x0 wants to merge 1 commit into
contputer0x0 wants to merge 1 commit into
Conversation
The djlint pre-commit hook (unpinned) now flags index.jinja2, which fails pre-commit.ci on current PRs. Fix the real findings and ignore the two that are intentional: - H024: drop the redundant type="text/css" on <style> and <link> (HTML5). - H043: add type="button" to the show/hide detail buttons. - H056/H057: ignore in [tool.djlint] with a note; the media <img>/<source> src is populated at runtime by report.js and the <video> has no caption source to track.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pre-commit.cicurrently fails on open PRs at thedjlinthook, which reports 7 findings insrc/pytest_html/resources/index.jinja2. The findings are pre-existing (not introduced by any particular PR): thedjlinthook is declared withadditional_dependencies: [djlint](unpinned), so as newer djlint releases tightened their rule set, the template started tripping checks that earlier cached runs onmasterdid not. The result is that unrelated PRs get a redpre-commit.ci.What this does
Fixes the real findings and ignores the two that are intentional:
type="text/css"on<style>and<link>(not needed in HTML5).type="button"to the Show all details / Hide all details buttons so they don't default tosubmit.[tool.djlint]ignorelist, with a comment: the media<img>/<source>srcis intentionally empty and populated at runtime byreport.js, and the<video>has no caption source to track.Verification
djlint src/pytest_html/resources/index.jinja2 --profile jinjawith the updated ignore list: 0 errors (was 7).type="text/css"and addingtype="button"do not change behavior). The existinglegacy_test_pytest_html.pystylesheet-link assertion checksrel="stylesheet"withouttype, so it still matches.