Repository navigation
Keep pytest-html extras on their owning result rows - #1078
Open
contputer0x0 wants to merge 4 commits into
Open
contputer0x0 wants to merge 4 commits into
contputer0x0 wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a test call passed but teardown failed, extras collected during setup, call, and teardown appeared on both result rows. This also affected setup/teardown failures and could mix assets across retries.
Each visible result row now keeps its own phase's extras. Extras from successful setup and teardown phases, whose rows are intentionally hidden, remain available on a visible row of the same test attempt. Attempt boundaries also keep rerun assets and captured teardown logs separate, and incomplete attempts are finalized before the report is written. Replayed deliveries of the same report object are processed only once; a genuinely separate failed teardown still produces an error row.
Verification
python -m pytest testing/test_unit.py testing/test_phase_attempts.py testing/test_integration.py testing/test_e2e.py -q: 124 passed with each ofpytest-rerunfailures15.1 and 16.7, including the Selenium-backed integration and end-to-end tests.npm run unit: 27 passed.npm run lintandnpm run build: passed.black --checkandflake8on the modified Python files: passed.djlintfindings in the unchangedsrc/pytest_html/resources/index.jinja2template. The same seven findings were reproduced on the upstream base commit, before this change. All other configured hooks passed.Fixes #1077.