Skip to content

feat(sequences): add offset query param to detections endpoint#592

Draft
ThbltLmr wants to merge 1 commit into
mainfrom
feat/sequences-detections-offset
Draft

feat(sequences): add offset query param to detections endpoint#592
ThbltLmr wants to merge 1 commit into
mainfrom
feat/sequences-detections-offset

Conversation

@ThbltLmr
Copy link
Copy Markdown
Collaborator

@ThbltLmr ThbltLmr commented May 14, 2026

Summary

  • Adds an offset query parameter to the GET /sequences/{sequence_id}/detections endpoint, wiring through the existing fetch_all offset support so callers can page through all detections of a sequence.

Test plan

  • New tests in src/tests/endpoints/test_sequences.py cover the offset behavior
  • Verify pagination works end-to-end against a populated sequence

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.15%. Comparing base (3a69b32) to head (b18ab1c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #592      +/-   ##
==========================================
+ Coverage   90.11%   90.15%   +0.04%     
==========================================
  Files          55       55              
  Lines        2498     2498              
==========================================
+ Hits         2251     2252       +1     
+ Misses        247      246       -1     
Flag Coverage Δ
backend 90.13% <ø> (+0.04%) ⬆️
client 90.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Wire the existing fetch_all offset support into fetch_sequence_detections
so callers can page through all detections of a sequence.
@ThbltLmr ThbltLmr force-pushed the feat/sequences-detections-offset branch from 0b377d6 to b18ab1c Compare May 14, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant