feat(alerts): unmatch a sequence from an alert#582
Open
MateoLostanlen wants to merge 10 commits into
Open
Conversation
Move the alert recomputation helper out of the sequences endpoint module so other endpoints can reuse it.
POST /alerts/{alert_id}/sequences/{sequence_id}/unmatch detaches a sequence from an alert and recomputes the alert state. If the sequence is no longer linked to any alert, a new alert is created for it. Restricted to admin and agent scopes; rejects unmatch when the alert has a single sequence.
Cover the new alert/sequence unmatch flow: new alert creation when the sequence becomes orphaned, no-op when the sequence is still linked elsewhere, single-sequence rejection, missing link, role and cross-org access denial.
Scope rejection from get_jwt returns 403, not 401. The label_sequence unit test now patches refresh_alert_state at its imported location.
Defensive guard so an authorized agent cannot trigger creation of an alert in another organization through a cross-org sequence link. Use the alert's organization_id when creating the replacement alert.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #582 +/- ##
==========================================
+ Coverage 90.09% 91.89% +1.80%
==========================================
Files 55 53 -2
Lines 2503 2419 -84
==========================================
- Hits 2255 2223 -32
+ Misses 248 196 -52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Wrap the new POST /alerts/{alert_id}/sequences/{sequence_id}/unmatch route.
Resolve conflicts in alerts.py and sequences.py imports + drop the duplicated _refresh_alert_state from sequences.py (already extracted to services/alerts.py). Update unmatch endpoint to pass detection_counts into the new _serialize_alert signature and chain delete().where() to satisfy mypy. Align unmatch tests with the 3-tuple return of _create_alert_with_sequences.
Newer requests releases ship inline types that require headers to be a MutableMapping[str, str | bytes], so Dict[str, str] no longer matches through the invariant generic. Widen the property accordingly and annotate the occlusion mask payload as Dict[str, Any] for the same reason. Add a smoke test for unmatch_alert_sequence to keep the new client wrapper covered.
SQLAlchemy/SQLModel async sessions schedule their actual I/O on a separate greenlet via greenlet_spawn, so coverage.py stops recording lines that execute after the first await on session.exec. This makes fully-tested async endpoints look uncovered in codecov reports. Adding concurrency = greenlet to both the root pyproject.toml and a new src/.coveragerc (which docker-compose.dev.yml mounts into the backend container) restores accurate line tracking. Locally the unmatch_alert_sequence body coverage jumps from 0% to ~95% and services/alerts.py from 62% to 93% without any test changes.
…nmatch # Conflicts: # client/pyroclient/client.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST /alerts/{alert_id}/sequences/{sequence_id}/unmatch(admin + agent) that detaches a sequence from an alert and recomputes the alert state; if the sequence becomes orphaned a new alert is created for it. Reject when the alert has a single sequence.refresh_alert_statefromendpoints/sequences.pyintoservices/alerts.pyso both endpoints share the helper.