Repository navigation
Pyjoyment.Plugin.Health, generate kubernetes: synchronous checks, an existing /healthz, liveness behind busy workers, and the budget of a stop - #610
Merged
Conversation
…existing /healthz, liveness behind busy workers, and the budget of a stop generate kubernetes takes --liveness-probe, a port for a liveness probe on tcpSocket, which the kernel accepts into the backlog behind the busy workers of prefork -c 1, or a path of its own, and --grace-period, which sets terminationGracePeriodSeconds and gives the graceful timeout of what the shutdown delay and 5 seconds leave of it, as 20 seconds of the 30 that Kubernetes gives by default. The documentation of Health says that its timeout bounds the checks of a promise or a coroutine, as a check that returns a value has run to its end before the timeout starts, which a test shows, that its endpoints take the paths of the routes and of a mounted application, which healthz=None leaves their /healthz, and the liveness on tcpSocket with -c 1; the cookbook and the skills deploy and mount say it too. Closes #566 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Docker Smoke Test
|
Contributor
Tests
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Healthbehind a synchronous application, as Django underMountonprefork -c 1, needs, in the plugin's docs and ingenerate kubernetes.Changes
generate kubernetes:--liveness-probe <port|path>: a port puts the liveness probe ontcpSocket, which the kernel accepts into the backlog behind busy workers of-c 1, where an HTTP probe waits and restarts a pod that is only busy; a path is anhttpGetof its own. The startup and the readiness probes stay the ones of the plugin. Anything else isUnknown liveness probe.--grace-period <seconds>:terminationGracePeriodSeconds, withPYJO_GRACEFUL_TIMEOUTof what the shutdown delay and 5 seconds leave of it, as 20 of the 30 seconds of the default of Kubernetes; an error with--graceful-timeout, or when nothing is left.Pyjoyment.Plugin.Healthdocs:Pyjo.IOLoop.blocking; a test shows a check that blocks longer than its timeout;healthz=Nonefor one with a/healthzof its own;tcpSocketwithprefork -c 1.--grace-period 30, and the liveness ontcpSocket.deployandmount: the options, the timeout of synchronous checks, andhealthz=None.Left out of the issue:
Mounton/matches every path, and the routes of a mounted application are not visible.Pyjo.Test.Pyjo(Guide and skill django: the tests of the routes of Pyjoyment in manage.py test, with close_old_connections detached #609) are done already.Validation
Pyjo.Reactor.PollwithPYTHONDEVMODE=1, without aResourceWarningkubectl kustomizeof the manifests with both options-W,trunk check,claude plugin validateCloses #566
🤖 Generated with Claude Code