Repository navigation
uv.lock: Pyjoyment of Git main at 1d48088, and event_loop_modules inherited - #3
Merged
Merged
Conversation
…erited Pyjoyment of Git main with pyjoyment/Pyjoyment#534, whose Pyjo.Reactor._finalize defers the cleanup of a finalizer below the frames of the module of the class of the reactor and of event_loop_modules. The reactor names no winloop: the loop of Winloop is compiled with Cython and makes no frames of Python, and a probe of _finalize over the suite of Pyjoyment on the reactor found no frame of Winloop below any of its calls. Closes #2 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Tests
|
uv on Windows takes the path of --python as it is, without .exe, so venv/Scripts/python was not found, and Build failed since #1. The directory of the virtual environment is found on every platform. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uv.locktakes Pyjoyment of Gitmainat 1d48088, with pyjoyment/Pyjoyment#534, which #2 needs.event_loop_modulesstays the inherited('asyncio', 'selectors'), withPyjo/Reactor/Winloop.pyand its_Loopcovered as the module of the class.Closes #2
Changes
uv.lock: Pyjoyment 25fbbfa → 1d48088 of Gitmain, with Pyjo.Reactor: event_loop_modules, and finalizers deferred below the frames of a reactor of another distribution or of its event loop Pyjoyment#534:event_loop_modulesofPyjo.Reactor, and finalizers deferred below the frames of a reactor of another distribution or of its event loopAGENTS.md: why the reactor names nowinloop(event_loop_modules of Pyjo.Reactor, so that finalizers defer their cleanups below the frames of the event loop #2). The loop of Winloop is compiled with Cython and makes no frames of Python, and the callbacks of the reactor run below_Loopor the methods ofPyjo.Reactor.Asyncio. The Python of the package is the code thatwinloop.runruns,runandwrapper, below which isasyncio/runners.py, whichasynciocovers already, and_noop.noop, which the loop calls to process the signals, where a signal handler or the garbage collector may run: between the callbacks of libuv, and below_Loopfor a loop of its ownAGENTS.md,pyproject.toml: the source of Gitmainis for Pyjo.Reactor: event_loop_modules, and finalizers deferred below the frames of a reactor of another distribution or of its event loop Pyjoyment#534 too, until the release of Pyjoyment after 0.2.0.github/workflows/build.yaml: the wheel installed withuv pip install --pythonof the directory of the virtual environment, as uv on Windows takes the path as it is, without.exe, sovenv/Scripts/pythonwas not found and Build failed since Pyjo.Reactor.Winloop: the reactor of Pyjoyment on Winloop #1Validation
t/of the repository withPYTHONDEVMODE=1, with the Pyjoyment ofuv.lockand with--with-editable ../PyjoymentPYTHONDEVMODE=1, on Windows: 434 files, 7018 tests, of which one fails:t/Pyjo/JSON_RPC.py, see belowPyjo.Reactor._finalizeover that suite: no frame of Winloop nor of a.pyxbelow any of its 3749 calls in 152 processes,t/stdlib/IOLoop_gc.pyamong themsphinx-build -Wtrunk check, not run locallyTests, which fails onmainalreadyKnown failure
t/Pyjo/JSON_RPC.py, subtestCalls of a closed peer, fails on every run on the reactor, also with the Pyjoyment ofmainbefore this change (25fbbfa), and fails the Tests ofmain. The writer of the socket sends to the peer that has closed it, and the nextrecvraisesConnectionAbortedError(WinError 10053).Pyjo.IOLoop.Stream._read_handlecloses the stream onConnectionResetErrorandBrokenPipeErroronly, so it emitserror, whichPyjo.IOLoop.Messagesemits again with no subscriber, soemitraises before.close(), and libuv reports the socket again and again. It is a fix of Pyjoyment:ConnectionAbortedErroras a close too, with which the test passes on the reactor.🤖 Generated with Claude Code