Repository navigation
Conversation
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #11799. Windows raises
PermissionErrorwhen the magic-number probe opens a directory, stopping engine detection before the Zarr backend can inspect the store.Handle that exception only when
os.path.isdir(path)is true. Permission errors for regular files still propagate. Tests cover the real Windows error, a simulated directory/file permission error, and automatic dataset opening with Zarr formats 2 and 3 using both strings and Path objects.Validation on Windows / Python 3.12.14: 6 focused failures before the fix; after the fix, the complete utils and backend-plugin modules pass (101 passed, 1 skipped: h5netcdf unavailable). An additional selected Zarr run passed 12 tests. Ruff 0.16.10 lint, format and docstring-preview checks passed, as did
git diff --check. Tests ran in an isolated uv environment; Pixi was unavailable.Checklist
AI Disclosure
Tools: Codex. Gabriel reviewed and confirmed understanding of the published diff before authorizing submission.
Prompt: “Continue contribuindo em outros projetos grandes e médios das nossas áreas, com correções relevantes e bem testadas. Quero ampliar nossa participação; só mencione IA quando o projeto exigir explicitamente.”
[This is Codex on behalf of Gabriel Demetrios Lafis.]