Repository navigation
Conversation
Document combine_attrs across combining APIs, including callable examples, attribute scopes, staged invocation, and interaction with compat. Co-authored-by: OpenAI Codex <noreply@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Document existing attribute-combination behavior without changing runtime behavior. The example combines source-name lists without modifying the inputs, and gives consistent results when combination happens in stages. Also clarify that
compat="identical"checks attributes even withcombine_attrs="drop".Related to #6679.
Validation
MergeError.git diff --checkpassed.The example handles source names stored as lists of strings; it is not a general attribute-merging policy. The full documentation site, full test suite, and complete pre-commit suite were not run locally.
Checklist
AI Disclosure
Prompt scope: review the supplied contribution candidates, explain their changes and limitations, and submit after human review.
The human submitter reviewed the changes and stated, in Chinese, that this documents existing behavior, accepts the described limitations, and takes responsibility for the contribution. The explanation above translates that reviewed rationale; validation results are recorded from the local runs.
[This is OpenAI Codex submitting on behalf of @ZFzuofeng, after their review and explicit authorization.]